Get notified #19
Merged
Get notified #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
commented
Sep 13, 2024
| @@ -19,12 +19,12 @@ | |||
| >.02</SectionNumber | |||
| > | |||
| <SlideIn> | |||
| <h2 class="title-100 -mt-[9px] sm:max-w-[280px] lg:max-w-[320px]">Taking back control</h2> | |||
| <h2 class="title-100 -mt-[9px] sm:max-w-[280px] sm:pr-5 lg:max-w-[320px]">Taking back control</h2> | |||
There was a problem hiding this comment.
These small padding bumps are so that the get notified button doesn't cover text.
wilwade
commented
Sep 13, 2024
| class="transition-all duration-1000" | ||
| /> | ||
| </svg> | ||
| <a href="/"> |
There was a problem hiding this comment.
Just added a link back to the home page as we have > 1 page now.
wilwade
commented
Sep 13, 2024
src/lib/assets/DiscordLogo.svg
Outdated
wilwade
commented
Sep 13, 2024
| @@ -0,0 +1,13 @@ | |||
| <script> | |||
There was a problem hiding this comment.
Added a "group" here so that home would have the scrolling stuff, but other (new) pages would not
wilwade
commented
Sep 13, 2024
src/routes/(home)/+page.svelte
Outdated
wilwade
commented
Sep 13, 2024
| <Footer /> | ||
| </div> | ||
| <div class="max-w-page overflow-x-hidden shadow-xl print:shadow-none"> | ||
| <slot /> |
There was a problem hiding this comment.
The new default layout is simpler. Also remove the shadow from the print version
wilwade
commented
Sep 13, 2024
| @@ -0,0 +1,15 @@ | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
Privacy layout is simple
wilwade
commented
Sep 13, 2024
src/routes/privacy/+page.svelte
Outdated
There was a problem hiding this comment.
Copied from the community rewards PP.
shannonwells
pushed a commit
that referenced
this pull request
Oct 25, 2024
closes #2 Co-authored-by: Claire Olmstead <olmsteadclaire@gmail.com>
shannonwells
pushed a commit
that referenced
this pull request
Oct 25, 2024
closes #11 blocked by #19 Note: Heather is working on licensing the correct font, so it looks a little off. ## Changes - added favicons - added minor layout styles - created header and nav components - made them accessible for both mobile and desktop ## Demo Uploading Screen Recording 2024-02-13 at 7.49.59 PM.mov… --------- Co-authored-by: Claire Olmstead <olmsteadclaire@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a get notified tag and form and privacy policy
Screenshot(s)
Type of change
Please delete options that are not relevant.
#frequency-xyzand remember that changes along the way triggerre-approval.)
How to Test?
Please describe how to test that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Checklist: